Skip to content

Enable more tests that were skipped #991

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 24, 2025
Merged

Enable more tests that were skipped #991

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
82f9186
Enable tests that were skipped on aarch64
tgross35 Jul 24, 2025
84507cc
Enable skipped `f32` and `f64` multiplication tests
tgross35 Jul 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 0 additions & 13 deletions builtins-test/src/bench.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,10 +17,6 @@ pub fn skip_sys_checks(test_name: &str) -> bool {
"extend_f16_f32",
"trunc_f32_f16",
"trunc_f64_f16",
// FIXME(#616): re-enable once fix is in nightly
// <https://github.com/rust-lang/compiler-builtins/issues/616>
"mul_f32",
"mul_f64",
];

// FIXME(f16_f128): system symbols have incorrect results
Expand All @@ -29,11 +25,6 @@ pub fn skip_sys_checks(test_name: &str) -> bool {
"add_f128", "sub_f128", "mul_f128", "div_f128", "powi_f32", "powi_f64",
];

// FIXME(f16_f128): Wide multiply carry bug in `compiler-rt`, re-enable when nightly no longer
// uses `compiler-rt` version.
// <https://github.com/llvm/llvm-project/issues/91840>
const AARCH64_SKIPPED: &[&str] = &["mul_f128", "div_f128"];

// FIXME(llvm): system symbols have incorrect results on Windows
// <https://github.com/rust-lang/compiler-builtins/issues/617#issuecomment-2121359807>
const WINDOWS_SKIPPED: &[&str] = &[
Expand All @@ -58,10 +49,6 @@ pub fn skip_sys_checks(test_name: &str) -> bool {
return true;
}

if cfg!(target_arch = "aarch64") && AARCH64_SKIPPED.contains(&test_name) {
return true;
}

if cfg!(target_family = "windows") && WINDOWS_SKIPPED.contains(&test_name) {
return true;
}
Expand Down
Loading