Skip to content

Commit 672143e

Browse files
committed
Auto merge of #623 - Mark-Simulacrum:opt, r=Mark-Simulacrum
Replace runner graph with single list Replace it with a single Vec which contains the list of crates to build; each worker just pops the next crate in the list and then executes all of the steps for that crate in series (reading configuration etc as necessary). We can in theory separate out the toolchains such that each worker only handles one toolchain (which would likely save disk space), but that is extra work and does not seem particularly beneficial at this time. It would also not be that hard to just duplicate the crate list N times and have each worker created with a specific toolchain and keep this setup almost as-is. Overall this is a much simpler approach, removing a considerable amount of complexity from the workers and essentially eliminating any worker thread synchronization (e.g., condvars, running/not running tasks, etc). Popping from the Vec of crates is fast and worker threads will terminate when the list is exhausted, but will otherwise just work on the next crate in queue. This nearly matches the current setup -- today a crate is likely scheduled in parallel for each toolchain across two worker threads -- but it shouldn't make a significant difference in overall runtimes. Based on #622.
2 parents b350b9f + 81ae92c commit 672143e

File tree

5 files changed

+122
-459
lines changed

5 files changed

+122
-459
lines changed

Cargo.lock

Lines changed: 0 additions & 23 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Cargo.toml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,6 @@ hyper = "0.12.8"
2828
lazy_static = "1.0"
2929
mime = "0.3.1"
3030
minifier = { version = "0.0.20", features = ["html"] }
31-
petgraph = "0.4.11"
3231
r2d2 = "0.8.2"
3332
r2d2_sqlite = "0.19.0"
3433
rusqlite = { version = "0.26.0", features = ["chrono", "functions", "bundled"] }

0 commit comments

Comments
 (0)