Replace GitIndex with db dumps + SparseIndex#794
Merged
Mark-Simulacrum merged 1 commit intorust-lang:masterfrom Aug 24, 2025
Merged
Replace GitIndex with db dumps + SparseIndex#794Mark-Simulacrum merged 1 commit intorust-lang:masterfrom
Mark-Simulacrum merged 1 commit intorust-lang:masterfrom
Conversation
Mark-Simulacrum
force-pushed
the
reduce-memory
branch
from
1391391 to
52d6be2
Compare
Contributor
|
Would it maybe make sense to use the db-dump crate for this?
|
Member
Author
|
I don't think that crate handles zip file parsing, which lets us avoid downloading the full dump - we touch a small portion of it, I haven't measured but my guess is <50%. And the logic isn't particularly complicated so I don't see much reason to add a dependency. |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Mark-Simulacrum
force-pushed
the
reduce-memory
branch
from
52d6be2 to
fc88199
Compare
Mark-Simulacrum
force-pushed
the
reduce-memory
branch
3 times, most recently
from
366fab9 to
775c24a
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
This reduces steady state memory usage for the server, in local testing, by several gigabytes, which should help us reduce instance size and/or cache more of the sqlite db pages in memory, possibly improving performance.
Mark-Simulacrum
force-pushed
the
reduce-memory
branch
from
775c24a to
dc800fa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reduces steady state memory usage for the server, in local testing, by several gigabytes, which should help us reduce instance size and/or cache more of the sqlite db pages in memory, possibly improving performance.