Skip to content

Conversation

dianne
Copy link

@dianne dianne commented Sep 4, 2025

This adds skip-test = true to the configuration for 16 of the test-failure crates from rust-lang/rust#145838 (comment). I've left more detailed comments about some of them in rust-lang/rust#145838 (comment).

There's 2 spurious failures I haven't included, since I'm less sure about what exactly is going wrong and couldn't confidently write a comment on why they should be excluded (but I'm pretty confident they're unrelated to the PR):

  • scirs2-autograd-0.1.0-alpha.6: test seems unreliable but I couldn't say why without spending time debugging it (it may have something to do with the concurrent access to shared global mutable state, which the test then checks at the end).
  • static-regular-grammar-2.0.2: I couldn't reproduce the failure; the failing doctest consistently passed when I tried it locally. Maybe there's a file I/O issue? It produces warnings about being unable to write, but I don't think those lead to the failure since they were present in previous crater runs when the tests all passed. Notably, the latest commit is also red from a test failure in the repository's CI, but it's old enough that I couldn't see why.

cc @jieyouxu

@Skgland
Copy link
Contributor

Skgland commented Sep 4, 2025

  • rskin-1.5.0: the repository link doesn't work anymore so I couldn't diagnose the failure.

What about using the source in the .crates file from crates.io https://crates.io/api/v1/crates/rskin/1.5.0/download?

@dianne
Copy link
Author

dianne commented Sep 4, 2025

Oh, thanks! I'd looked for a way to download from crates.io, but couldn't find it. It looks like it depends on filesystem layout (or at least that's where it fails locally for me, and on the same two tests). I'm not sure whether it's reliable for crater, but I've updated the PR to include it too.

@dianne dianne changed the title skip tests for 15 crates skip tests for 16 crates Sep 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants