RecordProgress for DatabaseDB (cli mode) fix to record result for the updated crate name#818
Open
azhogin wants to merge 1 commit intorust-lang:masterfrom
Open
Conversation
… updated crate name
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug in cli mode:
record_progressforDatabaseDBstores not updated crate name inresultstable. Whileupdate_crate_versionwrites updated crate name intoexperiment_cratestable. So, when report is generated, logs for the new crate name can't be found:Because results are stored for "brson/hello-rs", not "brson/hello-rs/9da3b03b25c2dfa8a8b8a69db503c48dbd08610e".
In agent mode this problem was already fixed in
pub fn store(...):This PR fixes the problem in cli mode in the similar way.