Skip to content

Commit d16c4c1

Browse files
committed
tests/owners: Simplify NewUser creation
There is no need for an "upsert" operation here since we know that the database is in a clean state in our tests. Additionally, this drops the need for the `Emails` implementation, since all we want is a user in the database, but without any email address confirmation emails being sent out.
1 parent 04b4c29 commit d16c4c1

File tree

1 file changed

+8
-4
lines changed

1 file changed

+8
-4
lines changed

src/tests/owners.rs

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@ use crate::{
1212
},
1313
};
1414

15+
use crate::schema::users;
1516
use chrono::{Duration, Utc};
1617
use diesel::prelude::*;
1718
use http::StatusCode;
@@ -724,15 +725,18 @@ async fn inactive_users_dont_get_invitations() {
724725
let invited_gh_login = "user_bar";
725726
let krate_name = "inactive_test";
726727

727-
NewUser {
728+
let user = NewUser {
728729
gh_id: -1,
729730
gh_login: invited_gh_login,
730731
name: None,
731732
gh_avatar: None,
732733
gh_access_token: "some random token",
733-
}
734-
.create_or_update(None, &app.as_inner().emails, &mut conn)
735-
.unwrap();
734+
};
735+
736+
diesel::insert_into(users::table)
737+
.values(user)
738+
.execute(&mut conn)
739+
.unwrap();
736740

737741
CrateBuilder::new(krate_name, owner.id).expect_build(&mut conn);
738742

0 commit comments

Comments
 (0)