Skip to content

Conversation

@Turbo87
Copy link
Member

@Turbo87 Turbo87 commented Nov 22, 2024

Now that we are using async database connections (almost) everywhere we can remove a lot of the code duplication that was introduced to enable the migration. At the same time we are dropping the async_ prefixes from these function, since they are not needed anymore and just clutter the code.

@Turbo87 Turbo87 added C-internal 🔧 Category: Nonessential work that would make the codebase more consistent or clear A-backend ⚙️ labels Nov 22, 2024
@codecov
Copy link

codecov bot commented Nov 22, 2024

Codecov Report

Attention: Patch coverage is 77.67857% with 25 lines in your changes missing coverage. Please review.

Project coverage is 89.45%. Comparing base (c645ab9) to head (0d703b7).
Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
src/bin/crates-admin/enqueue_job.rs 0.00% 16 Missing ⚠️
src/bin/crates-admin/delete_crate.rs 0.00% 3 Missing ⚠️
src/bin/crates-admin/yank_version.rs 0.00% 3 Missing ⚠️
src/bin/crates-admin/delete_version.rs 0.00% 2 Missing ⚠️
src/worker/jobs/archive_version_downloads.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10048      +/-   ##
==========================================
+ Coverage   88.95%   89.45%   +0.49%     
==========================================
  Files         295      295              
  Lines       31454    31243     -211     
==========================================
- Hits        27980    27947      -33     
+ Misses       3474     3296     -178     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@Turbo87 Turbo87 merged commit 05e3976 into rust-lang:main Nov 22, 2024
10 checks passed
@Turbo87 Turbo87 deleted the sync-cleanup branch November 22, 2024 09:31
@Turbo87 Turbo87 mentioned this pull request Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-backend ⚙️ C-internal 🔧 Category: Nonessential work that would make the codebase more consistent or clear

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant