Skip to content

Conversation

@Turbo87
Copy link
Member

@Turbo87 Turbo87 commented Nov 22, 2024

These were the last two API endpoints that were still using synchronous database operations. With this PR the two endpoints are now using diesel-async queries as well, allowing us to start the cleanup process of removing all of the duplicate sync functions.

Here is what GitHub Copilot has to say about the PR: 😅


This pull request includes several changes to the src/controllers/krate/owners.rs, src/models/crate_owner_invitation.rs, src/models/krate.rs, src/models/owner.rs, src/models/team.rs, and src/models/user.rs files to transition from synchronous to asynchronous database operations using diesel_async.

Key changes include:

Transition to Asynchronous Database Operations:

@Turbo87 Turbo87 added C-internal 🔧 Category: Nonessential work that would make the codebase more consistent or clear A-backend ⚙️ labels Nov 22, 2024
@codecov
Copy link

codecov bot commented Nov 22, 2024

Codecov Report

Attention: Patch coverage is 99.29078% with 1 line in your changes missing coverage. Please review.

Project coverage is 89.40%. Comparing base (05e3976) to head (8cd0ec5).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/controllers/krate/owners.rs 98.80% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10049      +/-   ##
==========================================
- Coverage   89.45%   89.40%   -0.06%     
==========================================
  Files         295      295              
  Lines       31243    31255      +12     
==========================================
- Hits        27949    27943       -6     
- Misses       3294     3312      +18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@Turbo87 Turbo87 merged commit f74a14e into rust-lang:main Nov 22, 2024
10 checks passed
@Turbo87 Turbo87 deleted the async-owners branch November 22, 2024 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-backend ⚙️ C-internal 🔧 Category: Nonessential work that would make the codebase more consistent or clear

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant