Skip to content

Conversation

@0xPoe
Copy link
Member

@0xPoe 0xPoe commented Dec 7, 2024

You can find these warnings when you run docker-compose:

❯ docker-compose up -d
WARN[0000] /Volumes/t7/code/crates.io/docker-compose.yml: the attribute `version` is obsolete, it will be ignored, please remove it to avoid potential confusion 
WARN[0000] /Volumes/t7/code/crates.io/docker-compose.override.yml: the attribute `version` is obsolete, it will be ignored, please remove it to avoid potential confusion 

See more at: https://docs.docker.com/reference/compose-file/version-and-name/#version-top-level-element-obsolete

@0xPoe 0xPoe requested a review from a team December 7, 2024 15:20
Copy link
Member Author

@0xPoe 0xPoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔢 Self-check (PR reviewed by myself and ready for feedback.)

@Turbo87 Turbo87 added the C-internal 🔧 Category: Nonessential work that would make the codebase more consistent or clear label Dec 7, 2024
@Turbo87 Turbo87 enabled auto-merge (squash) December 7, 2024 15:23
@Turbo87 Turbo87 disabled auto-merge December 7, 2024 15:23
@Turbo87 Turbo87 enabled auto-merge (squash) December 7, 2024 15:24
@Turbo87 Turbo87 changed the title chore: remove deprecated version attribute Docker: Remove deprecated version attribute Dec 7, 2024
@Turbo87 Turbo87 merged commit e5bfdde into rust-lang:main Dec 7, 2024
9 checks passed
@codecov
Copy link

codecov bot commented Dec 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.57%. Comparing base (3f611b9) to head (517d413).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #10155   +/-   ##
=======================================
  Coverage   89.57%   89.57%           
=======================================
  Files         295      295           
  Lines       31690    31690           
=======================================
  Hits        28386    28386           
  Misses       3304     3304           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@0xPoe 0xPoe deleted the rustin-patch-version branch December 7, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C-internal 🔧 Category: Nonessential work that would make the codebase more consistent or clear

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants