Skip to content

controllers/krate/delete: Adjust HTTP status code #10169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 10, 2024
Merged

controllers/krate/delete: Adjust HTTP status code #10169

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions src/controllers/krate/delete.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,11 @@ const AVAILABLE_AFTER: TimeDelta = TimeDelta::hours(24);
/// crate has been published for less than 72 hours, or if the crate has a
/// single owner, has been downloaded less than 100 times for each month it has
/// been published, and is not depended upon by any other crate on crates.io.
pub async fn delete(Path(name): Path<String>, parts: Parts, app: AppState) -> AppResult<()> {
pub async fn delete(
Path(name): Path<String>,
parts: Parts,
app: AppState,
) -> AppResult<StatusCode> {
let mut conn = app.db_write().await?;

// Check that the user is authenticated
Expand Down Expand Up @@ -107,7 +111,7 @@ pub async fn delete(Path(name): Path<String>, parts: Parts, app: AppState) -> Ap
})
.await?;

Ok(())
Ok(StatusCode::NO_CONTENT)
}

async fn find_crate(conn: &mut AsyncPgConnection, name: &str) -> QueryResult<Option<Crate>> {
Expand Down Expand Up @@ -177,7 +181,7 @@ mod tests {
");

let response = delete_crate(&user, "foo").await;
assert_eq!(response.status(), StatusCode::OK);
assert_eq!(response.status(), StatusCode::NO_CONTENT);
assert!(response.body().is_empty());

// Assert that the crate no longer exists
Expand Down Expand Up @@ -212,7 +216,7 @@ mod tests {
");

let response = delete_crate(&user, "foo").await;
assert_eq!(response.status(), StatusCode::OK);
assert_eq!(response.status(), StatusCode::NO_CONTENT);
assert!(response.body().is_empty());

// Assert that the crate no longer exists
Expand Down Expand Up @@ -247,7 +251,7 @@ mod tests {
");

let response = delete_crate(&user, "foo").await;
assert_eq!(response.status(), StatusCode::OK);
assert_eq!(response.status(), StatusCode::NO_CONTENT);
assert!(response.body().is_empty());

// Assert that the crate no longer exists
Expand Down