Skip to content

Update dependency ember-data to v5 #10355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 9, 2025
Merged

Update dependency ember-data to v5 #10355

merged 1 commit into from
Jan 9, 2025

Conversation

@renovate
Copy link
Contributor

@renovate renovate bot commented Jan 9, 2025

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
ember-data (source) 4.12.8 -> 5.3.9 age adoption passing confidence

Release Notes

emberjs/data (ember-data)

v5.3.9

Compare Source

v5.3.8

Compare Source

v5.3.7

Compare Source

v5.3.6

Compare Source

v5.3.5

Compare Source

v5.3.4

Compare Source

🌲 New Deprecation
📝 Documentation
🚀 Enhancement
🐛 Bug Fix
🏠 Internal
Committers: (2)

Chris Thoburn (@​runspired)
@​NullVoxPopuli

For the full project changelog see https://github.com/emberjs/data/blob/main/CHANGELOG.md

v5.3.3: | I won't lie, it won't be easy

Compare Source

v5.3.3 (2024-03-02)

🐛 Bug Fix
Committers: (1)

Chris Thoburn (@​runspired)

v5.3.2: | Make the music stop before it starts

Compare Source

v5.3.2 (2024-02-29)

🏠 Internal
Committers: (1)

Chris Thoburn (@​runspired)

v5.3.1

Compare Source

🚀 Enhancement
🐛 Bug Fix
🏠 Internal
Committers: (3)

Chris Thoburn (@​runspired)
Eric Kelly (@​HeroicEric)
Krystan HuffMenne (@​gitKrystan)

v5.3.0: | don't forget, baby, I'm a wildcard

Compare Source

The Big Picture

This release primarily focused on polish for the RequestManager story, introducing builder utils, builders for REST ActiveRecord and JSON:API requests as well as serialization utils for JSON:API requests.

As part of shipping serialization utils, we implemented several long-awaited cache features to support them:

  • cache.changedRelationships retrieves a diff of what has been added or removed from each relationship for a resource
  • cache.hasChangedRelationships answers whether any relationships have changed for a resource
  • cache.rollbackRelationships will reset all relationships for that resource to their "remote" state, removing any local changes.

As part of our ongoing efforts to modernize the library and to support the above changes, we implemented several new deprecations.

  • Deprecate legacy import paths (ember-data/) except for ember-data/store
  • Deprecate non-strict-type (e.g. "users" or "myType" instead of "user" and "my-type")
  • Deprecate non-strict-id (e.g . 1 instead of "1")

And in relationships specifically:

  • deprecate fixing non-unique relationship payloads (when the same record is referenced multiple times in a related collection)
  • deprecate remote updates clearing local changes (an upcoming blog post will explain the new behavior here in detail)

Changelog (2023-09-18)

🚀 Enhancement
🐛 Bug Fix
🌲 New Deprecation
🚿 Deprecation Removal
  • adapter, model, private-build-infra, serializer
📝 Documentation
🥅 Test
🏠 Internal
Committers: 11

v5.2.0: | I could've taken you places

Compare Source

Changelog (2023-08-17)

  • Re-release of 5.1.2 to keep lockstep pace. This release contains no new work.
5.1.2 Contained the following changes
🐛 Bug Fix

v5.1.2: | Now I've had time to think it over

Compare Source

Changelog (2023-08-17)

🐛 Bug Fix

v5.1.1: - I know it was wrong, but never said I was sorry

Compare Source

Changelog (2023-07-07)

🐛 Bug Fix
Committers: 1

v5.1.0: - We went to Hell, but we never came back

Compare Source

Changelog (2023-06-29)

🐛 Bug Fix
  • #​8657 fix: ensure deprecation configs are threaded to each package (@​runspired)
  • #​8649 fix: NotificationManager should only invoke resource/document callbacks owned by the originating store (@​runspired)
Committers: 1

v5.0.1

Compare Source

🐛 Bug Fix
  • #​8649 fix: NotificationManager should only invoke resource/document callbacks owned by the originating store (@​runspired)
Committers: 1

v5.0.0: - Rose Colored Lenses

Compare Source

rose-lenses

This release removes code deprecated during 4.x.

🎵 We could stay like this forever.

Changelog

🐛 Bug Fix
🚿 Deprecation Removal
📝 Documentation
Committers: 4

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.

  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@Turbo87
Copy link
Member

Turbo87 commented Jan 9, 2025

@eth3lbert looks like your deprecation fixes solved our upgrade issues 🎉

could you double-check on your side whether you see any issues with this upgrade? :)

@eth3lbert
Copy link
Contributor

eth3lbert commented Jan 9, 2025

@eth3lbert looks like your deprecation fixes solved our upgrade issues 🎉

could you double-check on your side whether you see any issues with this upgrade? :)

Nice, this is great news!

I checked out and ran both QUnit and e2e tests.

All is good except for some deprecations and a single flaky test case in e2e, as follows:

[percy] Percy is not running, disabling snapshots
  1) [chromium] › acceptance/read-only-mode.spec.ts:34:7 › Acceptance | Read-only Mode › client errors are reported on sentry @acceptance 

    Error: expect(received).toBe(expected) // Object.is equality

    Expected: 1
    Received: 0

      46 | async function checkSentryEventsNumber(ember: AppFixtures['ember'], expected: number) {
      47 |   let len = await ember.evaluate(owner => owner.lookup('service:sentry').events.length);
    > 48 |   expect(len).toBe(expected);
         |               ^
      49 | }
      50 |
      51 | async function checkSentryEventsHasName(ember: AppFixtures['ember'], expected: string[]) {
        at checkSentryEventsNumber (/Users/eth3lbert/workspace/rust-lang/crates.io/e2e/acceptance/read-only-mode.spec.ts:48:15)
        at /Users/eth3lbert/workspace/rust-lang/crates.io/e2e/acceptance/read-only-mode.spec.ts:41:5

[chromium] › acceptance/search.spec.ts:4:7 › Acceptance | search › searching for "rust" @acceptance
[percy] Percy is not running, disabling snapshots
  1 failed
    [chromium] › acceptance/read-only-mode.spec.ts:34:7 › Acceptance | Read-only Mode › client errors are reported on sentry @acceptance 
  2 skipped
  195 passed (47.4s)

But it seems harmless to me. I'm not sure how it happened. I guess the assertion was faster than it received the 404 from the request?"

@Turbo87
Copy link
Member

Turbo87 commented Jan 9, 2025

All is good except for some deprecations

yeah, some new deprecations are to be expected, but as long as they are not converted to failures that's fine and can be addressed later.

a single flaky test case in e2e

hmm interesting. do you have time to investigate/fix or should we merge and address it later?

@eth3lbert
Copy link
Contributor

eth3lbert commented Jan 9, 2025

hmm interesting. do you have time to investigate/fix or should we merge and address it later?

Since this is a new flaky test that hasn't been found on CI, only on my machine, and it's not a fatal issue, I think we could merge first and address it later.

@Turbo87 Turbo87 merged commit bbe5345 into main Jan 9, 2025
9 checks passed
@Turbo87 Turbo87 deleted the renovate/ember-data-5.x branch January 9, 2025 11:15
@eth3lbert eth3lbert mentioned this pull request Jan 10, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

A-frontend 🐹

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Turbo87 @eth3lbert