crate/delete: Add required reason input field #10380
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turbo87
added
C-enhancement ✨
Turbo87
force-pushed
the
delete-reason-input
branch
from
b66a163 to
8719a86
Compare
LawnGnome
approved these changes
Jan 14, 2025
Contributor
|
🙋 Should we add a test case for sending with no reason input? |
Member
Author
|
I won't say no if someone added one :D |
eth3lbert
reviewed
Jan 14, 2025
|
|
||
| let reason = snapshot.adapterOptions.reason; | ||
| if (reason) { | ||
| url += `?reason=${encodeURIComponent(reason)}`; |
Contributor
There was a problem hiding this comment.
@Turbo87 🙋 If I understand correctly, the query string is named message at the backend
crates.io/src/controllers/krate/delete.rs
Lines 24 to 29 in 19c80e0
reason. I think this might be a mistake?
Member
Author
There was a problem hiding this comment.
damn, you're right... 🤦♂️
Turbo87
added a commit
to Turbo87/crates.io
that referenced
this pull request
Jan 14, 2025
Turbo87
added a commit
that referenced
this pull request
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in our last team meeting, this pull requests adds a required "Reason" input field to the crate deletion page: