controllers/krate/search: Use provided plainto_tsquery_with_search_config() fn
#10411
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eth3lbert
added
C-internal 🔧
Turbo87
reviewed
Jan 17, 2025
…onfig()` fn Instead of hand-crafting SQL ourselves, this leverages the defined `plainto_tsquery_with_search_config()` function from the `diesel_full_text_search`.
eth3lbert
force-pushed
the
diesel-full-text
branch
from
b5bb9c5 to
3e1acc8
Compare
Turbo87
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, I used the wrong function, and the correct function was not available at that time.
The correct function
plainto_tsquery_with_search_config()respects toplainto_tsquery(config regconfig, query text ) → tsqueryis now available 1, and our test cases cover this part. I think it's time we switched to using it :DRelated:
Footnotes
https://github.com/diesel-rs/diesel_full_text_search/pull/41 ↩