Add ?include=versions support for GET /api/v1/crates/{name}/downloads endpoint
#10529
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eth3lbert
force-pushed
the
download-include-versions
branch
2 times, most recently
from
ffadb14 to
781715a
Compare
eth3lbert
commented
Feb 7, 2025
Contributor
Author
There was a problem hiding this comment.
The versions should only be used to display the count on the crate page. Therefore, I think it should be safe to remove this test case. Let me know if this is inappropriate.
Turbo87
reviewed
Feb 10, 2025
Turbo87
added
C-enhancement ✨
eth3lbert
force-pushed
the
download-include-versions
branch
from
781715a to
6124efd
Compare
eth3lbert
commented
Feb 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While #10344 is merged, we currently include the
default_version. Ideally, we should not load all versions for the index/version page. However, there are still some blockers. One blocker isVersionDownloaddue to itsbelongsTorelationship withversion. This requires us to wait forversionsto be loaded before loadingdownloads.This PR aims to add an include mode to the
GET /api/v1/crates/{name}/downloadsendpoint. This allows it to include the relatedversionsand avoids the need to wait forversionsto be fully loaded in app.