Skip to content

Conversation

@Turbo87
Copy link
Member

@Turbo87 Turbo87 commented Feb 11, 2025

This dependency on the PaginationOptions struct makes it hard to eventually extract our database model code into a dedicated crate. Since we only need the offset and limit for this query we can just pass it in directly and move the dependency into the controller that is already using PaginationOptions anyway.

@Turbo87 Turbo87 added C-internal 🔧 Category: Nonessential work that would make the codebase more consistent or clear A-backend ⚙️ labels Feb 11, 2025
@Turbo87 Turbo87 merged commit a3f5833 into rust-lang:main Feb 12, 2025
10 checks passed
@Turbo87 Turbo87 deleted the pagination-options-in-models branch February 12, 2025 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-backend ⚙️ C-internal 🔧 Category: Nonessential work that would make the codebase more consistent or clear

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant