Skip to content

models/user: Change gh_access_token field to SecretString #10573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 13, 2025
Merged

models/user: Change gh_access_token field to SecretString #10573

merged 3 commits into from
Feb 13, 2025

Conversation

@Turbo87
Copy link
Member

@Turbo87 Turbo87 commented Feb 13, 2025

The struct has a Debug implementation, so we should be using SecretString to redact it from the output and avoid other accidental leakages.

@Turbo87 Turbo87 added C-internal 🔧 Category: Nonessential work that would make the codebase more consistent or clear A-backend ⚙️ labels Feb 13, 2025
@Turbo87 Turbo87 merged commit 10241e3 into rust-lang:main Feb 13, 2025
10 checks passed
@Turbo87 Turbo87 deleted the secret-token branch February 13, 2025 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

A-backend ⚙️ C-internal 🔧 Category: Nonessential work that would make the codebase more consistent or clear

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@Turbo87