Skip to content

WIP sekrit project #10610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

WIP sekrit project #10610

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
1ff570e
Duplicate GitHub OAuth info to a linked_accounts table (deploy 1)
carols10cents Feb 17, 2025
7ba4532
(untested) SQL to backfill linked_accounts (deploy 2)
carols10cents Feb 21, 2025
e2116b3
Add a username field to the users table (deploy 3?)
carols10cents Feb 19, 2025
49124ba
(untested) SQL to backfill username (deploy 4)
carols10cents Mar 5, 2025
19125bb
Transition views to use username instead of login (deploy 5)
carols10cents Mar 4, 2025
83fac29
Send linked accounts in user JSON (deploy 6)
carols10cents Mar 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions script/backfill-linked-accounts.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
INSERT INTO linked_accounts (user_id, provider, account_id, access_token, login, avatar)
Copy link

@blm768 blm768 Nov 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll likely want a benchmark on this to see if it takes long enough that it needs to be broken into smaller batches, but my instinct says this approach is probably fine.

Copy link
Member Author

@carols10cents carols10cents Nov 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I'm starting to think I want a more general sort of harness for running SQL in a loop of batches of N until it returns 0 results, because a few of these migrations are going to need to do that sort of thing...

SELECT id, 0, gh_id, gh_access_token, gh_login, gh_avatar
FROM users
LEFT JOIN linked_accounts
ON users.id = linked_accounts.user_id
WHERE gh_id != -1
AND linked_accounts.user_id IS NULL;