Skip to content

Adjust styles for crate row #10776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 7, 2025
Merged

Adjust styles for crate row #10776

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f7e6529
crate-row: Enable hover selector only when a pointer is available
eth3lbert Mar 7, 2025
388a6cf
crate-row: Adjust styles for improved alignment and spacing
eth3lbert Mar 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/components/crate-row.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<div local-class="crate-row" data-test-crate-row ...attributes>
<div local-class="description-box">
<div>
<div local-class="crate-spec">
{{#let (link "crate" @crate.id) as |l|}}
<a href={{l.url}} local-class="name" data-test-crate-link {{on "click" l.transitionTo}}>
{{@crate.name}}
Expand Down
44 changes: 29 additions & 15 deletions app/components/crate-row.module.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,37 +23,51 @@
overflow-wrap: break-word;
}

.version {
margin-left: var(--space-2xs);
}

.copy-button {
composes: button-reset from '../styles/shared/buttons.module.css';
padding: 0 var(--space-2xs);
color: var(--main-color);
cursor: pointer;
opacity: 0;
transition: var(--transition-medium);

.crate-row:hover & {
opacity: .8;
transition: var(--transition-instant);
}
/* Hover selector for pointer only */
/* See: https://github.com/rust-lang/crates.io/issues/10772 */
@media (pointer: fine) {
opacity: 0;
transition: var(--transition-medium);

.crate-row:hover &:hover, &:focus {
opacity: 1;
transition: var(--transition-instant);
.crate-row:hover & {
opacity: .8;
transition: var(--transition-instant);
}

.crate-row:hover &:hover, &:focus {
opacity: 1;
transition: var(--transition-instant);
}
}

svg {
vertical-align: top;
height: 1rem;
width: 1rem;
}
}

.crate-spec {
display: flex;
flex-wrap: wrap;
align-items: center;

& > * {
margin-bottom: calc(var(--space-xs) / 2);
}
& > :not(last-child) {
margin-right: var(--space-2xs);
}
}

.description {
composes: small from '../styles/shared/typography.module.css';
margin-top: var(--space-xs);
margin-top: calc(var(--space-xs) / 2);
line-height: 1.5;
}

Expand Down
Loading