Skip to content

controllers/krate/delete: remove the temporary language from #10591 #10777

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 7, 2025
Merged

controllers/krate/delete: remove the temporary language from #10591 #10777

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 1 addition & 7 deletions app/templates/crate/delete.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,13 +21,7 @@
<div local-class="requirements">
<h3>Requirements:</h3>
<p>
A crate can only be deleted if it is not depended upon by any other crate on crates.io. (This is a temporary
restriction due to
<a
href='https://github.com/rust-lang/crates.io/issues/10538'
target='_blank'
rel='noopener noreferrer'
>#10538</a>.)
A crate can only be deleted if it is not depended upon by any other crate on crates.io.
</p>
<p>Additionally, a crate can only be deleted if either:</p>
<ol local-class='first'>
Expand Down
3 changes: 1 addition & 2 deletions src/controllers/krate/delete.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,8 +99,7 @@ pub async fn delete_crate(
}
}

// Temporary hack to mitigate https://github.com/rust-lang/crates.io/issues/10538: all crates
// with reverse dependencies are currently blocked from being deleted to avoid unexpected
// All crates with reverse dependencies are blocked from being deleted to avoid unexpected
// historical index changes.
if has_rev_dep(&mut conn, krate.id).await? {
let msg = "only crates without reverse dependencies can be deleted";
Expand Down
Loading