Return errors if metadata name or version do not match manifest #10960
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
since this fixes a significant bug I'll go ahead and merge it. I'd still appreciate a review afterwards if anyone has time :) |
LawnGnome
reviewed
Apr 9, 2025
Contributor
LawnGnome
left a comment
LawnGnome
left a comment
There was a problem hiding this comment.
After the fact: LGTM. I don't see any downside to doing this. 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently get the package name and version in three places in a publish request: the JSON metadata blob, the path prefix inside the crate tarball, and the
Cargo.tomlmanifest inside the crate tarball. Up until now we were primarily relying on the JSON metadata and verifying the path prefixes. Apparently we were not checking the content of theCargo.tomlmanifest though.This PR fixes the issue by explicitly checking the manifest fields too and returning errors in case of a mismatch.