sentry: remove Authorization header values before send
#10995
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LawnGnome
added
C-internal 🔧
Turbo87
reviewed
Apr 11, 2025
src/sentry/mod.rs
Outdated
|
|
||
| // Also remove `Authorization`, just so it never even gets sent to Sentry, even if | ||
| // they're redacting it downstream. | ||
| request.headers.remove(AUTHORIZATION.as_str()); |
Member
There was a problem hiding this comment.
mhhh... is this case-insensitive?
Contributor
Author
There was a problem hiding this comment.
Ugh, no — my brain vapour locked on AUTHORIZATION being HeaderName, never mind that it's obviously becoming a &str to handle the BTreeMap<String, String> that we actually have.
Thanks. Good catch. I'd blame Friday brain, but it's even more Friday for you.
Turbo87
approved these changes
Apr 11, 2025
Member
Turbo87
left a comment
Turbo87
left a comment
There was a problem hiding this comment.
hard to review the tests on mobile but the actual code LGTM 👍
Contributor
Author
All good, thanks. Just wanted the basic sanity check after my earlier Friday morning brain. I owe you a beer or two. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These get redacted in the Sentry ingest, but why send them at all?