Simplify NewVersion::save() fn
#11290
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Version::save()` fn This prepares for the "Trusted Publishing" implementation, where there is no associated user account for a release and thus no email address either. Moving the call outside of the transaction is fine since the only production code call is already happening in an outer transaction.
Now that we only perform a single database query in this function we don't need this transaction anymore. The only caller in production code is already using an outer transaction anyway.
…ublished_by::insert()` call We don't need this in the database for the test cases in this module.
Turbo87
added
C-internal 🔧
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no need for this function to use a transaction since the only place that this is used in production is already using an outer transaction.
It is also questionable whether the
INSERT INTO versions_published_byneeds to happen in the same function, since there are plenty of other inserts that need to happen when a new version is published, but neither of them are part of this function either.In the effort of making
crates_io_databasean easy to reason about data access layer, this PR adjusts theNewVersion::save()fn to only save the new version to theversionstable, and moves theversions_published_byinsert code outside of the function.