crate/settings: Hide "Add Owner" form behind "Add Owner" button #11301
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turbo87
added
C-enhancement ✨
LawnGnome
approved these changes
Jun 5, 2025
Contributor
LawnGnome
left a comment
LawnGnome
left a comment
There was a problem hiding this comment.
This is definitely better. 👍
| Username | ||
| </label> | ||
| <Input @type="text" id="new-owner-username" @value={{this.username}} placeholder="Username" local-class="email-input" name="username" /> | ||
| <button type="submit" disabled={{not this.username}} class="button button--small" data-test-save-button>Save</button> |
Contributor
There was a problem hiding this comment.
I tend to like specific verbs on forms, so maybe:
Suggested change
| <button type="submit" disabled={{not this.username}} class="button button--small" data-test-save-button>Save</button> | |
| <button type="submit" disabled={{not this.username}} class="button button--small" data-test-save-button>Add Owner</button> |
Member
Author
There was a problem hiding this comment.
hahaha, I have a commit here already for a follow-up PR that pretty much does that 😂
This form does not need a dedicated header and does not need to be visible all the time. This commit hides it until the user explicitly clicks the "Add Owner" button. This frees up space on the page to add the list of "Trusted Publishing" configurations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This form does not need a dedicated header and does not need to be visible all the time. This commit hides it until the user explicitly clicks the "Add Owner" button. This frees up space on the page to add the list of "Trusted Publishing" configurations.
Before
After