tests: Replace assert_eq! with assert_snapshot! for status code checks
#11346
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turbo87
force-pushed
the
status-snapshots
branch
from
2b3b2d7 to
0ce682e
Compare
Turbo87
added
C-internal 🔧
Turbo87
force-pushed
the
status-snapshots
branch
from
0ce682e to
4c21c3e
Compare
Turbo87
force-pushed
the
status-snapshots
branch
from
4c21c3e to
d9df4b9
Compare
…hecks This commit updates test assertions to use `insta::assert_snapshot!` for HTTP status code checks across various test files. This makes it easier to update the assertions in case status codes for certain errors are changed/fixed. Unfortunately, this changes the numbering of the file-based snapshots, which causes the diff to look much larger than it actually is... 🙈
Turbo87
force-pushed
the
status-snapshots
branch
from
d9df4b9 to
7c3731e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates test assertions to use
insta::assert_snapshot!for HTTP status code checks across various test files. This makes it easier to update the assertions in case status codes for certain errors are changed/fixed.Unfortunately, this changes the numbering of the file-based snapshots, which causes the diff to look much larger than it actually is... 🙈