worker: Fix tracing instrumentation #11358
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For some reason only background jobs with the `#[instrumented]` annotation were receiving the `job.id` and `job.typ` fields from the parent span. This commit adjusts the `span` usage to not require the annotation and attach these fields for all background jobs.
Turbo87
added
C-internal 🔧
Turbo87
added a commit
to Turbo87/crates.io
that referenced
this pull request
Jun 14, 2025
This was unintentionally upgraded in rust-lang#11358...
Turbo87
added a commit
that referenced
this pull request
Jun 14, 2025
This was unintentionally upgraded in #11358...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason only background jobs with the
#[instrumented]annotation were receiving thejob.idandjob.typfields from the parent span. This commit adjusts thespanusage to not require the annotation and attach these fields for all background jobs.