Use encrypted GitHub OAuth access tokens #11697
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turbo87
added
the
C-enhancement ✨
Member
Author
|
@rust-lang/crates-io unless anyone has objections, I plan on merging and deploying this on Thursday |
Turbo87
force-pushed
the
use-encrypted-tokens
branch
from
028489b to
993ab8c
Compare
This reverts commit d36c99999fe40bac32a227088eafdb049a6db4fe.
Turbo87
force-pushed
the
use-encrypted-tokens
branch
from
993ab8c to
d9aab69
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the second phase described in #11585. It makes the
gh_encrypted_tokencolumn non-nullable and adjusts our code to use the encrypted tokens instead of the plaintext ones.The PR also removes the now obsolete
encrypt-github-tokensadmin tool again, since the backfill has been performed on both environments and since it was filtering ongh_encrypted_token IS NULL, it wasn't compatible with the migration anymore.