Fix unintentional crate.newest_version reset
#11795
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turbo87
force-pushed
the
newest-version-reset
branch
from
c6744c4 to
f8f0a5a
Compare
The `GET /summary` call correctly initialized the `newest_version` fields of the crates, but when navigating to the crate page, the `GET /crate/foo` call by default uses an `include` query parameter that excludes the `newest_version` field from being loaded on the backend, which causes it to be returned with a value of `0.0.0` (for legacy reasons). This then reset the field on the model, causing it to be displayed incorrectly when navigating back to the front page. This commit fixes the issue by adjusting the crate serializer to ignore `0.0.0` values for `max_version` and `newest_version`, so that they won't override previously loaded values.
Turbo87
force-pushed
the
newest-version-reset
branch
from
f8f0a5a to
4b5d091
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
GET /summarycall correctly initialized thenewest_versionfields of the crates, but when navigating to the crate page, theGET /crate/foocall by default uses anincludequery parameter that excludes thenewest_versionfield from being loaded on the backend, which causes it to be returned with a value of0.0.0(for legacy reasons). This then reset the field on the model, causing it to be displayed incorrectly when navigating back to the front page.This commit fixes the issue by adjusting the crate serializer to ignore
0.0.0values formax_versionandnewest_version, so that they won't override previously loaded values.Resolves #11772