-
Notifications
You must be signed in to change notification settings - Fork 691
Migrate frontend builds from webpack to Vite #11814
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
| }, | ||
| "scripts": { | ||
| "build": "ember build --environment=production && node ./script/precompress-assets.mjs", | ||
| "build": "vite build", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should probably keep the precompress-assets.mjs call 😉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yea there is going to be loads that needs fixing on this branch, and a bunch of stuff like this was automatically changed with the codemod.
For this specific thing... shouldn't that work be done with a rollup/vite plugin rather than a "post build script" ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
something like this: https://www.npmjs.com/package/rollup-plugin-gzip (this was literally the first result when searching so I'm not actually proposing this explicitly)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
probably, but this worked well enough and we only need it for the production deployment so spending more time on the investigation wasn't worth it 😉
No description provided.