Add Cloudfront invalidations queue to the database #11836
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turbo87
added
the
C-internal 🔧
Turbo87
force-pushed
the
cloudfront-invalidations
branch
from
4cce58d to
909bb22
Compare
Turbo87
force-pushed
the
cloudfront-invalidations
branch
from
909bb22 to
231426b
Compare
Turbo87
force-pushed
the
cloudfront-invalidations
branch
from
231426b to
ace6a30
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new
cloudfront_invalidation_queuedatabase table that tracks which paths need to be invalidated. The PR also adds aProcessCloudfrontInvalidationQueuebackground job, which sends invalidation requests to CloudFront until the queue is empty.The reason for this implementation is that CloudFront has a hard limit on the number of invalidations that can be processed concurrently, and we are occasionally hitting these limits on workspace publishes or when deleting larger batches of spam crates.