webpack: Avoid SVG file inlining #11936
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While this works and can be beneficial, it conflicts with our Content Security Policy (https://developer.mozilla.org/en-US/docs/Web/HTTP/Guides/CSP) setting in production, so let's avoid the inlining for now until we can figure out a way to improve compatibility between the two.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While this works and can be beneficial, it conflicts with our Content Security Policy (https://developer.mozilla.org/en-US/docs/Web/HTTP/Guides/CSP) setting in production, so let's avoid the inlining for now until we can figure out a way to improve compatibility between the two.
This is how the token expiry dropdown is supposed to look like:
and this is how it currently looks like in production:
This PR fixes the issue :)