Show SLoC values in crate page sidebars #11955
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turbo87
added
the
C-enhancement ✨
Turbo87
commented
Sep 22, 2025
This extends the API serialization to include linecount statistics in version responses by adding a `linecounts` field to the `EncodableVersion` struct and updating the OpenAPI specification to document the new field. All API response test snapshots across crates and versions endpoints are updated to include the new linecount data. The implementation maintains backward compatibility with `null` linecount values for existing data.
This updates the Mock Service Worker test infrastructure to include linecount data by extending the version model with a `linecounts` field and mock data generation. All MSW handler tests are updated to include linecount in API responses, providing realistic mock linecount data for frontend testing.
This implements linecount display in the crate sidebar by adding a `linecounts` attribute to the `Version` Ember Data model and displaying total code lines alongside existing crate size information. A code icon is included for visual consistency with other metrics. The implementation handles `null` linecount data gracefully for backward compatibility.
Turbo87
force-pushed
the
sloc-display
branch
from
4012b53 to
50bac71
Compare
jtgeibel
approved these changes
Sep 26, 2025
LawnGnome
approved these changes
Sep 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#11453 is merged and the backfill has finished, so now we can start showing the SLoC estimates next to the crate file size as another data point:
Related