Skip to content

Add ARIA heading role to crate search results #11999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 29, 2025
Merged

Add ARIA heading role to crate search results #11999

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/components/crate-row.gjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ import truncateText from 'crates-io/helpers/truncate-text';
<template>
<div data-test-crate-row ...attributes class='crate-row'>
<div class='description-box'>
<div class='crate-spec'>
<div data-test-crate-spec class='crate-spec' role='heading' aria-level='2'>
{{#let (link_ 'crate' @crate.id) as |l|}}
<a href={{l.url}} class='name' data-test-crate-link {{on 'click' l.transitionTo}}>
{{@crate.name}}
Expand Down
1 change: 1 addition & 0 deletions e2e/acceptance/search.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ test.describe('Acceptance | search', { tag: '@acceptance' }, () => {
);
await expect(page.locator('[data-test-crate-row="0"] [data-test-crate-link]')).toHaveText('kinetic-rust');
await expect(page.locator('[data-test-crate-row="0"] [data-test-version]')).toHaveText('v0.0.16');
await expect(page.locator('[data-test-crate-row="0"] [data-test-crate-spec]')).toHaveRole('heading');

await expect(page.locator('[data-test-crate-row="0"] [data-test-description]')).toHaveText(
'A Kinetic protocol library written in Rust',
Expand Down
Loading