-
Notifications
You must be signed in to change notification settings - Fork 691
Add Computational Chemistry, Computational Biology, and Materials Science Categories to Science
#12730
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
TKanX
wants to merge
11
commits into
rust-lang:main
Choose a base branch
from
TKanX:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+92
−35
Open
Add Computational Chemistry, Computational Biology, and Materials Science Categories to Science
#12730
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
140fbf3
Add Structural Biology category under Bioinformatics
TKanX 1d9d900
Add Chemistry category and subcategories for Physical Chemistry and C…
TKanX e535e79
Fix formatting inconsistencies in category descriptions in categories…
TKanX c745940
Rename Structural Biology category to Structural Bioinformatics
TKanX c903826
Add Materials Science category under Science
TKanX 1ca0d19
Standardizes category descriptions to clarify crate focus
TKanX 9d56971
Remove Chemistry and Materials Science categories from categories.toml
TKanX bcb66d2
Add Computational Chemistry category and subcategories
TKanX e3d385f
Add Computational Biology category and subcategories
TKanX 75db173
Add Materials Science category under Science with description
TKanX 874ec72
Remove Structural Informatics category from Computational Biology (Sc…
TKanX File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm, we already have the "Bioinformatics" category below. having a "Computational Biology" category next to it seems a little confusing to me... 😅
is there some way we can resolve this? can we merge them? rename the new one in some way?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I actually started with that exact approach (see 140fbf3). However, during the discussion, we realized it’s better to distinguish between sequence biology (2D) and structural biology (3D).
As noted in this feedback:
@yesint @Luthaf Do you have any suggestions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fncnt @Turbo87 Do you have any suggestions?