Extract cargo-registry-index package
#4396
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turbo87
added
A-backend ⚙️
C-internal 🔧
Turbo87
force-pushed
the
index-crate
branch
3 times, most recently
from
1a836eb to
2707b85
Compare
|
☔ The latest upstream changes (presumably #4440) made this pull request unmergeable. Please resolve the merge conflicts. |
Turbo87
force-pushed
the
index-crate
branch
3 times, most recently
from
a21e8ed to
41bd32d
Compare
We will extract the `git` module into a dedicated crate in one of the next commits. This would be impossible if the crate had to depend on the main crate, since it would result in a cyclic dependency.
|
@bors r+ |
|
📌 Commit c0d68c3 has been approved by |
|
☀️ Test successful - checks-actions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extracts our code to deal with the package index into a dedicated
cargo-registry-indexcrate. This should make it faster to recompile just this part of the code and run the corresponding tests. It also ensures a somewhat clean boundary between the different code areas.