Skip to content

Conversation

@Turbo87
Copy link
Member

@Turbo87 Turbo87 commented Oct 1, 2024

Fixes #6135. Closes #6168.

Compared to #6168, this PR implements the fix in a way that features depending on newer syntax are recursively moved to features2 instead of moving them all unconditionally.

Probably best reviewed commit-by-commit :)

/cc @rust-lang/cargo

@Turbo87 Turbo87 requested a review from a team October 1, 2024 12:55
@Turbo87 Turbo87 added C-bug 🐞 Category: unintended, undesired behavior A-backend ⚙️ labels Oct 1, 2024
@codecov
Copy link

codecov bot commented Oct 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.11%. Comparing base (2e5a4fe) to head (187b3c9).
Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9551      +/-   ##
==========================================
+ Coverage   89.07%   89.11%   +0.04%     
==========================================
  Files         286      287       +1     
  Lines       28940    29053     +113     
==========================================
+ Hits        25779    25892     +113     
  Misses       3161     3161              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Turbo87 Turbo87 merged commit 2d33f01 into rust-lang:main Oct 4, 2024
10 checks passed
@Turbo87 Turbo87 deleted the split-features branch October 4, 2024 09:37
@weihanglo
Copy link
Member

👋🏾! Is the migration of this done for all relevant crate index files.

@Turbo87
Copy link
Member Author

Turbo87 commented Oct 8, 2024

@weihanglo yes and no. we only triggered a manual sync for clap. the other crates will update whenever they release a new version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-backend ⚙️ C-bug 🐞 Category: unintended, undesired behavior

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

features2 in index broke cargo backward compatibility

3 participants