Skip to content

Conversation

@Turbo87
Copy link
Member

@Turbo87 Turbo87 commented Oct 4, 2024

There is only a single write query in this code path, so the transaction is somewhat unnecessary. This also simplifies the confirmation code a little bit since it doesn't have to rely on exit(0) anymore.

@Turbo87 Turbo87 added C-internal 🔧 Category: Nonessential work that would make the codebase more consistent or clear A-backend ⚙️ labels Oct 4, 2024
There is only a single write query in this code path, so the transaction is somewhat unnecessary. This also simplifies the confirmation code a little bit since it doesn't have to rely on `exit(0)` anymore.
@codecov
Copy link

codecov bot commented Oct 4, 2024

Codecov Report

Attention: Patch coverage is 0% with 11 lines in your changes missing coverage. Please review.

Project coverage is 88.90%. Comparing base (429e1be) to head (30c52a2).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/admin/transfer_crates.rs 0.00% 11 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9582   +/-   ##
=======================================
  Coverage   88.90%   88.90%           
=======================================
  Files         289      289           
  Lines       29123    29124    +1     
=======================================
+ Hits        25892    25893    +1     
  Misses       3231     3231           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Turbo87 Turbo87 merged commit cf322b4 into rust-lang:main Oct 4, 2024
10 checks passed
@Turbo87 Turbo87 deleted the exit-0 branch October 4, 2024 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-backend ⚙️ C-internal 🔧 Category: Nonessential work that would make the codebase more consistent or clear

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant