worker/jobs: Use DEDUPLICATED for jobs where it makes sense
#9628
+19
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Most of our background jobs don't need to be enqueued multiple times if there is already a similar one in the queue. This commit changes most of the jobs to use the new `DEDUPLICATED` flag on the `BackgroundJob` impl.
Turbo87
added
C-internal 🔧
LawnGnome
approved these changes
Oct 11, 2024
Contributor
LawnGnome
left a comment
LawnGnome
left a comment
There was a problem hiding this comment.
OK, so I think that means the ones that aren't going to be de-duplicated are:
ProcessCdnLogQueueNormalizeIndexRenderAndUploadReadme
Feels like this should be OK.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9628 +/- ##
=======================================
Coverage 88.87% 88.87%
=======================================
Files 289 289
Lines 29232 29232
=======================================
Hits 25981 25981
Misses 3251 3251 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of our background jobs don't need to be enqueued multiple times if there is already a similar one in the queue. This commit changes most of the jobs to use the new
DEDUPLICATEDflag on theBackgroundJobimpl.