Skip to content

Remove CI system detection #9643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 15, 2024
+1 −77
Merged

Remove CI system detection #9643

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/renovate.json5
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@
groupName: "diesel packages",
},
{
matchDepNames: ["aws-ip-ranges", "github-meta"],
matchDepNames: ["aws-ip-ranges"],
automerge: true,
},
{
Expand Down
11 changes: 0 additions & 11 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,6 @@ diesel_migrations = { version = "=2.2.0", features = ["postgres"] }
dotenvy = "=0.15.7"
flate2 = "=1.0.34"
futures-util = "=0.3.31"
github-meta = "=0.11.0"
hex = "=0.4.3"
http = "=1.1.0"
http-body-util = "=0.1.2"
Expand Down
60 changes: 0 additions & 60 deletions src/ci.rs
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,6 @@ mod app;
pub mod auth;
pub mod boot;
pub mod certs;
pub mod ci;
pub mod cloudfront;
pub mod config;
pub mod controllers;
Expand Down
3 changes: 0 additions & 3 deletions src/middleware/log_request.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
//! Log all requests in a format similar to Heroku's router, but with additional
//! information that we care about like User-Agent
use crate::ci::CiService;
use crate::controllers::util::RequestPartsExt;
use crate::headers::XRequestId;
use crate::middleware::normalize_path::OriginalPath;
Expand Down Expand Up @@ -36,7 +35,6 @@ pub struct RequestMetadata {
real_ip: Extension<RealIp>,
user_agent: Option<TypedHeader<UserAgent>>,
request_id: Option<TypedHeader<XRequestId>>,
ci_service: Option<CiService>,
}

pub async fn log_requests(
Expand Down Expand Up @@ -87,7 +85,6 @@ pub async fn log_requests(
http.status_code = status.as_u16(),
cause = response.extensions().get::<CauseField>().map(|e| e.0.as_str()).unwrap_or_default(),
error.message = response.extensions().get::<ErrorField>().map(|e| e.0.as_str()).unwrap_or_default(),
ci = %request_metadata.ci_service.map(|ci| ci.to_string()).unwrap_or_default(),
%custom_metadata,
"{method} {url} → {status} ({duration:?})",
);
Expand Down
Loading