Skip to content

Conversation

@Turbo87
Copy link
Member

@Turbo87 Turbo87 commented Oct 27, 2024

With all_columns the field order inside the structs is very important and it is impossible to skip columns. as_select() solves both of these issues.

With `all_columns` the field order inside the structs is very important and it is impossible to skip columns. `as_select()` solves both of these issues.
@Turbo87 Turbo87 added C-internal 🔧 Category: Nonessential work that would make the codebase more consistent or clear A-backend ⚙️ labels Oct 27, 2024
@codecov
Copy link

codecov bot commented Oct 27, 2024

Codecov Report

Attention: Patch coverage is 96.29630% with 1 line in your changes missing coverage. Please review.

Project coverage is 88.79%. Comparing base (3de6c20) to head (1838132).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/admin/render_readmes.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9768      +/-   ##
==========================================
- Coverage   88.80%   88.79%   -0.01%     
==========================================
  Files         289      289              
  Lines       29816    29809       -7     
==========================================
- Hits        26479    26470       -9     
- Misses       3337     3339       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Turbo87 Turbo87 merged commit e873809 into rust-lang:main Oct 27, 2024
10 checks passed
@Turbo87 Turbo87 deleted the all-columns branch October 27, 2024 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-backend ⚙️ C-internal 🔧 Category: Nonessential work that would make the codebase more consistent or clear

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant