mirage: Add default_version and yanked to crate serializer

[eth3lbert]

This PR adds default_version and yanked to the crate serializer.

Related:

• Expose the default_version on the API #9741
• Expose the yanked field on the API #9817

[Turbo87]

are you sure that we need these mentioned here? I would've thought that those are only necessary for the fields that come directly from the corresponding factory/model

[eth3lbert]

I saw we have

crates.io/mirage/route-handlers/summary.js

Lines 25 to 35 in a46fcdc

	just_updated: this.serialize(just_updated).crates.map(it => ({ ...it, versions: null })),
	most_downloaded: this.serialize(most_downloaded).crates.map(it => ({ ...it, versions: null })),
	new_crates: this.serialize(new_crates).crates.map(it => ({ ...it, versions: null })),
	most_recently_downloaded: this.serialize(most_recently_downloaded).crates.map(it => ({
	...it,
	versions: null,
	})),
	num_crates,
	num_downloads,
	popular_categories: this.serialize(popular_categories).categories,
	popular_keywords: this.serialize(popular_keywords).keywords,

which leverages serializer. So I just made the change in the serializer.

[eth3lbert]

But after your awareness, I think we might also want to change the factory and fixture as well?

[Turbo87]

I'm not sure I understand what you're saying 😅

my question is: do the tests work the same as before when these two lines are removed again? or is something breaking then?

[eth3lbert]

Oh, my bad, I thought it was necessary to add these, that was quite embarrassing! A quick inspection of the mirage response confirms your absolute right.

[eth3lbert]

I have removed the attrs part.

---

Should we add these fields to mirage/factory or mirage/fixtures?

[Turbo87]

Should we add these fields to mirage/factory or mirage/fixtures?

no :)

factory is for regular fields, model is for relationships, fixtures can die for all I care, and the serializer can be (mis)used for "computed" fields 😉

[eth3lbert]

TIL!!