worker/tests: Fix flaky deduplication test #9865
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The second `assert_none!()` in this test was occasionally failing due to a race condition. The `TestJob` that was enqueued right before this one would sometimes already be processed before we enqueue this one, leading to this one being actually enqueued instead of being deduplicated. The reason for this was that the `runner()` fn builds a `Runner` with two workers for the default queue. This commit changes the runner to only use a single worker, which avoids the race condition.
Turbo87
added
C-internal 🔧
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9865 +/- ##
=======================================
Coverage 88.86% 88.86%
=======================================
Files 289 289
Lines 30000 30002 +2
=======================================
+ Hits 26659 26662 +3
+ Misses 3341 3340 -1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The second
assert_none!()in this test was occasionally failing due to a race condition. TheTestJobthat was enqueued right before this one would sometimes already be processed before we enqueue this one, leading to this one being actually enqueued instead of being deduplicated. The reason for this was that therunner()fn builds aRunnerwith two workers for the default queue. This commit changes the runner to only use a single worker, which avoids the race condition.