models/crate_owner_invitation: Convert to async/await #9890
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes `spawn_blocking()` usage from `PUT /api/v1/me/crate_owner_invitations/:crate_id` and `PUT /api/v1/me/crate_owner_invitations/accept/:token` endpoints. Converts `CrateOwnerInvitation::accept()` and `CrateOwnerInvitation::decline()` to async fns.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9890 +/- ##
=======================================
Coverage 88.99% 88.99%
=======================================
Files 290 290
Lines 30086 30096 +10
=======================================
+ Hits 26776 26785 +9
- Misses 3310 3311 +1 ☔ View full report in Codecov by Sentry. |
Turbo87
approved these changes
Nov 10, 2024
Turbo87
added
C-internal 🔧
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR converts most functions in the
crate_owner_invitationmodel to async/await and removes unnecessaryspawn_blocking()usage in the controller. Thecreatefunction is left unconverted due to additional work required, which I plan to address in a future PR :)