Skip to content

Conversation

@Turbo87
Copy link
Member

@Turbo87 Turbo87 commented Nov 10, 2024

This should be our last place that still used a sync reqwest client :)

I tested this locally by hardcoding cdn_prefix: Some("https://static.crates.io".to_string()) and then running cargo run --bin crates-admin render-readmes --crate mustache --page-size 5. seemed to work fine from what I could tell.

@Turbo87 Turbo87 requested a review from eth3lbert November 10, 2024 16:53
@Turbo87 Turbo87 added C-internal 🔧 Category: Nonessential work that would make the codebase more consistent or clear A-backend ⚙️ labels Nov 10, 2024
@codecov
Copy link

codecov bot commented Nov 10, 2024

Codecov Report

Attention: Patch coverage is 0% with 81 lines in your changes missing coverage. Please review.

Project coverage is 89.00%. Comparing base (23fa915) to head (669b247).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/bin/crates-admin/render_readmes.rs 0.00% 81 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9892   +/-   ##
=======================================
  Coverage   88.99%   89.00%           
=======================================
  Files         290      290           
  Lines       30096    30095    -1     
=======================================
  Hits        26785    26785           
+ Misses       3311     3310    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@eth3lbert eth3lbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 !

We could further utilize async-compression and tokio-tar and remove spawn_blocking() in a future PR.

@Turbo87 Turbo87 merged commit 31c98b4 into rust-lang:main Nov 10, 2024
10 checks passed
@Turbo87 Turbo87 deleted the async-render branch November 10, 2024 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-backend ⚙️ C-internal 🔧 Category: Nonessential work that would make the codebase more consistent or clear

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants