use crate name normalization when trying to delete crates / releases #2620
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
S-waiting-on-review
syphar
force-pushed
the
crate-delete-normalize
branch
from
fe4e5ca to
6425322
Compare
GuillaumeGomez
approved these changes
Sep 28, 2024
github-actions
bot
added
S-waiting-on-deploy
syphar
removed
the
S-waiting-on-deploy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a case with a crate called
Horizon_Data_Types, which then was deleted on crate.io (I assume via support request).Interestingly we had the crate in our db as
Horizon_Data_Types, while the delete change from the crates.io index came ashorizon_data_types. That delete-request then failed because we didn't find the name.See https://rust-lang.sentry.io/issues/5128144333/?environment=production&project=5499376&query=&referrer=issue-stream&statsPeriod=90d&stream_index=4
The following build of the same crate as a new crate with a different name (
horizon-data-types) then lead to a conflict error because we check uniqueness of crate names after normalization.Error: https://rust-lang.sentry.io/issues/5913176075/?environment=production&project=5499376&query=&referrer=issue-stream&statsPeriod=90d&stream_index=1
This change will use normalization when handling deletes.