Properly link licenses on crate pages #2739
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
S-waiting-on-review
Manishearth
force-pushed
the
license-page
branch
from
73a5523 to
0378bdf
Compare
Member
Author
|
Here's what it currently looks like
A little cramped. It tries to preserve whitespace choices in the original SPDX. We could use a proper SPDX parser and normalize, but I think showing the original license string is actually good here. |
GuillaumeGomez
approved these changes
Feb 19, 2025
Member
|
Great work, thanks a lot! Don't worry about CSS, I'll send a follow-up. |
Member
|
Clippy errors and |
Manishearth
force-pushed
the
license-page
branch
from
0378bdf to
749fad8
Compare
Member
|
Fmt is failing now. 😉 |
Member
Author
|
Yes, I can read the CI, you don't need to tell me about the failures 😄 |
Fixes rust-lang#2738 I'm not happy with the styling but I simply don't understand the CSS here well enough to do better without putting in significant effort. I decided to consistently link to SPDX instead of also trying to link to https://choosealicense.com/ likes crates.io, but it's an easy change to make if we want to add that too.
Manishearth
force-pushed
the
license-page
branch
from
749fad8 to
9372b5c
Compare
Member
Author
|
Done, probably. |
GuillaumeGomez
approved these changes
Feb 20, 2025
Member
|
All good, thanks! Sending a follow-up for the CSS. |
github-actions
bot
added
S-waiting-on-deploy
syphar
removed
the
S-waiting-on-deploy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2738
I'm not happy with the styling but I simply don't understand the CSS here well enough to do better without putting in significant effort.
I decided to consistently link to SPDX instead of also trying to link to https://choosealicense.com/ likes crates.io, but it's an easy change to make if we want to add that too.