Skip to content

ensure current tracing span is passed into streaming html rewrite #2874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 29, 2025

Conversation

syphar
Copy link
Member

@syphar syphar commented Jul 29, 2025

I want to

  • see the parent spans from the request when logging errors while rewriting
  • have a separate span for performance tracing the rewriter.

Coming from these errors, where I want to see if they are flakes.

I'm also thinking of adding spans to the tokio-task & the render-in-threadpool call, but in there we don't log anything.

@syphar syphar requested a review from a team as a code owner July 29, 2025 05:26
@github-actions github-actions bot added S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed labels Jul 29, 2025
@syphar syphar self-assigned this Jul 29, 2025
@syphar syphar merged commit bfdb522 into rust-lang:master Jul 29, 2025
11 checks passed
@syphar syphar deleted the span branch July 29, 2025 08:43
@github-actions github-actions bot added S-waiting-on-deploy This PR is ready to be merged, but is waiting for an admin to have time to deploy it and removed S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed labels Jul 29, 2025
@GuillaumeGomez GuillaumeGomez removed the S-waiting-on-deploy This PR is ready to be merged, but is waiting for an admin to have time to deploy it label Jul 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants