Skip to content

Simplify GUI test script #2916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 11, 2025
Merged

Simplify GUI test script #2916

merged 2 commits into from
Sep 11, 2025

Conversation

GuillaumeGomez
Copy link
Member

No description provided.

@GuillaumeGomez GuillaumeGomez requested a review from a team as a code owner September 7, 2025 15:11
@github-actions github-actions bot added S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed labels Sep 7, 2025
@GuillaumeGomez
Copy link
Member Author

@syphar PR ready. :)

syphar
syphar approved these changes Sep 11, 2025
View reviewed changes
Copy link
Member

@syphar syphar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't really judge if this is the best approach, or if there are better alternative.

But high level it looks good, and from the logs it seems to work.

So I'm fine with it.

@GuillaumeGomez
Copy link
Member Author

Then I merge. :)

@GuillaumeGomez GuillaumeGomez merged commit 3c96ae9 into rust-lang:master Sep 11, 2025
9 checks passed
@GuillaumeGomez GuillaumeGomez deleted the simplify-gui branch September 11, 2025 20:23
@github-actions github-actions bot added S-waiting-on-deploy This PR is ready to be merged, but is waiting for an admin to have time to deploy it and removed S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed labels Sep 11, 2025
@syphar syphar removed the S-waiting-on-deploy This PR is ready to be merged, but is waiting for an admin to have time to deploy it label Sep 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@syphar syphar syphar approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@GuillaumeGomez @syphar