Skip to content

Conversation

syphar
Copy link
Member

@syphar syphar commented Oct 9, 2025

I extracted the actual error from CI logs:

Documenting stylish-core v0.1.2 (/opt/rustwide/workdir)
: feature has been removed
   --> src/lib.rs:10:38
    |
 10 | #![cfg_attr(docsrs, feature(doc_cfg, doc_auto_cfg))]
    |                                      ^^^^^^^^^^^^ feature has been removed
    |
    = note: removed in CURRENT_RUSTC_VERSION; see <https://github.com/rust-lang/rust/pull/138907> for more information
    = note: merged into `doc_cfg`
 
 error: Compilation failed, aborting rustdoc
 
 For more information about this error, try `rustc --explain E0557`.
 error: could not document `stylish-core`

So it's not fixed in the version yet.

So I added a custom crate that only contains what we want to test.

please validate my assumption for the test case, I'm basing my test just on the name of the test.

@syphar syphar self-assigned this Oct 9, 2025
@github-actions github-actions bot added the S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed label Oct 9, 2025
@syphar
Copy link
Member Author

syphar commented Oct 9, 2025

I created a PR to the library itself: Nullus157/stylish-rs#38

@syphar syphar changed the title build-tests: upgrade stylish-core to fix build-test built-tests: use custom crate to test implicit optional-dependency features aren't there Oct 10, 2025
@syphar syphar marked this pull request as ready for review October 10, 2025 09:32
@syphar syphar requested a review from a team as a code owner October 10, 2025 09:32
@syphar
Copy link
Member Author

syphar commented Oct 10, 2025

@GuillaumeGomez I migrated our code to use a custom local crate for testing.

Can you confirm my thought about what case the test should cover, and if the test-crate correctly covers it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants