Skip to content

docs: Document that pushurl_bytes returns null if no push url is set #1124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 6, 2025
Merged

docs: Document that pushurl_bytes returns null if no push url is set #1124

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/remote.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,12 +152,14 @@ impl<'repo> Remote<'repo> {

/// Get the remote's pushurl.
///
/// Returns `None` if the pushurl is not valid utf-8
/// Returns `None` if the pushurl is not valid utf-8 or no special url for pushing is set.
pub fn pushurl(&self) -> Option<&str> {
self.pushurl_bytes().and_then(|s| str::from_utf8(s).ok())
}

/// Get the remote's pushurl as a byte array.
///
/// Returns `None` if no special url for pushing is set.
pub fn pushurl_bytes(&self) -> Option<&[u8]> {
unsafe { crate::opt_bytes(self, raw::git_remote_pushurl(&*self.raw)) }
}
Expand Down