Make Binding public #940
Make Binding public #940
Conversation
|
@edrevo You might need to rebase and ping the bot to make this PR get reviewed/merged. |
|
@rustbot ready |
| #[doc(hidden)] | ||
| /// Provides access to the raw libgit2 pointer to be able to interact with libgit2-sys. | ||
| /// | ||
| /// If you are going to depend on this trait on your code, do consider contributing to the git2 |
There was a problem hiding this comment.
I love this being called out. Thank you.
There was a problem hiding this comment.
How does exporting this trait sound? It would allow for an escape hatch to be able to interact with libgit2-sys.
I think the change is small and fine to merge. However, I'd like to understand what can't be done or hard to do before this patch. Would you mind showing some examples of before and after?
There was a problem hiding this comment.
The reason I initially pinged @edrevo to update the PR and ping rustbot to get it merged was because of WorktreeAddOptions missing an API to set checkout_options.
I ended up solving it a different way and I was in fact holding it wrong, but giving the user the capability to access the underlying C-API seems generally useful.
Fixes #928
This allows users to use the libgit2-sys binding for things that might not have git2 support yet.